ILIAS icon indicating copy to clipboard operation
ILIAS copied to clipboard

Published 20 hours ago • verified publisher icon ILIAS-eLearning

Setup: Tree trunk_30847 add tree to setup

Open daniwe4 opened this issue 3 years ago • 10 comments

  • ensure tree is in environment during setup

daniwe4 avatar Jun 18 '21 14:06 daniwe4

Hi @smeyer-ilias,

I assigned this to you as the maintainer of Services/Tree. We found that some migrations or objectives will need a tree to work correctly, so we propose to add this objective to the service to make that dependency expressible.

Best regards!

klees avatar Jun 23 '21 15:06 klees

Hi @smeyer-ilias

this came up again in our last TB meeting on the 19-10-2021. Is there anything new regarding this PR? Is there anything we could do to speed up the process?

Best regards!

chfsx avatar Oct 19 '21 11:10 chfsx

SetupAgent is deleted.

daniwe4 avatar Oct 29 '21 07:10 daniwe4

Hi @smeyer-ilias As Technical Board, we regularly check for pull requests that have been open for a long time. As the assignee, if you don't have any objections, please merge this PR or provide feedback otherwise.

Best regards!

chfsx avatar Nov 30 '21 10:11 chfsx

@smeyer-ilias This would be extremely helpful to move the code in Services/Migration to Objectives as agreed upon in the PHP8-Working-Group. Could you look into this soon? Is there anything we can do to accelerate this?

klees avatar Dec 20 '21 11:12 klees

Hi @smeyer-ilias

we stumbled upon this PR in our TB meeting. Any updates on this?

Best regards!

mjansenDatabay avatar Feb 08 '22 12:02 mjansenDatabay

Hi @smeyer-ilias As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this?

Best regards!

Amstutz avatar May 17 '22 09:05 Amstutz

Hi @smeyer-ilias As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this?

Best regards!

Amstutz avatar Jun 14 '22 08:06 Amstutz

Hi @smeyer-ilias As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this?

Best regards!

Amstutz avatar Aug 09 '22 10:08 Amstutz

Dear @smeyer-ilias While checking on old open PRs in the frame of our Technical Board Meeting we stumbled over this one that is getting a little long in the tooth. Could you please either close it with an explanation, give feedback or ask @daniwe4 to resolve the conflicts and merge? Thank you very much! @kergomard in the name of the TB

kergomard avatar Oct 04 '22 05:10 kergomard

Hi @smeyer-ilias

As Technical Board, we regularly check for pull requests that have been open for a long time. Any Updates on this? Note, that you can also close this, if you are not able or if you not have the ressources to look into it in detail.

Best regards!

chfsx avatar Jan 24 '23 12:01 chfsx

We understand the requirement to have the tree available in the setup, but we close this PR.

The major issue are the many workarounds in the initEnvironment function. E.g. the logger availability might just be a separate objective. In general the ilTree class should have a proper dependency injection for all the things that are added via DIC here. It is quite hard to estimate if all these workarounds really work properly, e.g. the user object, or if not something crucial is missing.

We are hoping to find a new maintainer for the tree component that finds the time to take care of this properly in the near future.

alex40724 avatar Apr 26 '23 08:04 alex40724