T&A10 45505: Hides grade and passes status when test is yet unfinished

[matheuszych]

https://mantis.ilias.de/view.php?id=45505

Aims to hide grades and passes status when test is yet unfinished.

Already reviewed by @thojou.

[kergomard]

Thank you very much for the PR @matheuszych !

I do not think this is correct as it also changes the overview table. There is a comment that there should be no changes to the overview table in 10 and above. What am I missing?

This is important:

• If the participant has currently passed the test and has a valid amount of points from a previous attempt, this should be shown. I'm unsure what the correct behavior is, if the test is set to evaluate the last attempt? If a participant has a valid attempt already that she has passed the test with, does an unfinished attempt invalidate that result or not, i.e. is the result from the previous attempt valid until the started attempt is finished? I would think: "Last attempt" means "last attempt" and thus a participant that has started a new attempt has no valid result until this attempt is finished, but this really is stipulation. Maybe @dsstrassner has a good read of the situation.

Thanks again and best, @kergomard

[dsstrassner]

Thanks for being patient.

I would agree that a result should only be shown if an attempt is finished!

If the test is set to "Score the Last Attempt"

Attempt 1 is started --> do not show any results? Attempt 1 is finished, and attempt 2 is started --> show the result of attempt 1. Attempt 2 is finished, and attempt 3 is started --> show the result of attempt 2.

[matheuszych]

Hello @kergomard , Hello @dsstrassner ,

Thank you for your reviews! I adjusted the code where necessary.

Some of the changes are for example the following. When a attempt is not finished yet:

• Test Results in Points shows -
• Test Results in Marks shows -
• Rank of Participant shows -
• Scored Test Attempt shows -

Also when you press Show Results in the actions menu you get redirected to the Test Attempt Overview. If the newest test attempt is not finished yet, you get redirected to the previous attempt. If there is no previous attempt you will be shown the current (potentially unfinished) attempt.

Best regards @matheuszych

[jweber-unibe]

I wonder if it is correct to not show the points for a running attempt (if I understand the state of the discussion here and in the Mantis report correctly).

As long as the points for a running attempt are presented in the results overview – as they should from my POV, similar to @kergomard's "no changes to the overview table" (if I understand that correctly) – I can't see the point of suppressing them in the detailed results.

And esp. because of the option to access ones own results 'immediately', i.e. even during a running attempt, I don't think it reasonable to suppress the results completely for this attempt.

Am I getting this right or do I miss the most relevant point?

[dsstrassner]

I agree with you, @jweber-unibe: From my point of view, results are a mark and the status for the attempt: failed or passed. Points should/must always be shown. They are part of the results, since the mark and the status are derived from them, but in the first place, the points are in the flow as long as the scoring is not finished by the responsible person. But we (=test admin) always need to see them. Hopefully we are now all on the same side?

[thojou]

Hey all,

yes, we already discussed this topic this morning and @matheuszych has updated the details view to streamline the behavior between the table and details views.

From our point of view, both the understanding and the code should now be fully aligned.

Best Regards, @thojou

[dsstrassner]

Hey all,

yes, we already discussed this topic this morning and @matheuszych has updated the details view to streamline the behavior between the table and details views.

From our point of view, both the understanding and the code should now be fully aligned.

Best Regards, @thojou

Yeah, I thought that, but I also wanted to leave a paper trail for documentation purposes and commented therefore. 🗡️

Thanks to all for their efforts to reach a complete and good solution. :grin:

[thojou]

Hey all,

thanks for your efforts. I've integrated the changes into release_10, release_11 and trunk.

Best Regards, @thojou