T&A 44724: Fixes sizing issue with checkboxes and radio elements in print view of single and multiple choice questions

[matheuszych]

https://mantis.ilias.de/view.php?id=44724

Aims to fix sizing issue with checkboxes and radio elements in print view of single and multiple choice questions.

Already reviewed by @thojou.

[kergomard]

Thank you very much for the PR @matheuszych !

Where does the magic number 13 come from? Could we tie it to something somewhere? This for me like it will break on any custom template.

Thanks and best, @kergomard

[thojou]

Hey @kergomard,

I think @matheuszych was following the existing implementation in survey question print views, where the 13px is defined for checkboxes.

You make a good point though. @matheuszych, could we move this from inline styles to a proper CSS selector instead? This would be more maintainable.

Best regards, @thojou

[matheuszych]

Hello @kergomard ,

i added the new css class. I hope i put it into the correct file. Could you please assign the correct person to review the changes?

Best regards @matheuszych

[kergomard]

Hi @matheuszych

Thank you very much! I think we can mostly keep it as it is, but couldn't we bind this to a variable? What about setting it to $il-font-size-base? You could make it even better by first importing it to an internal variable $il-test-icon-min-size. See _component_test.scss for examples on how to do that. We then assign the CSS authorities for them to agree, before we can merge.

This document deserves a look.

Thanks and best, @kergomard

[matheuszych]

Hello @kergomard ,

i introduced the new sccs variable $il-test-icon-min-size and linking it to $il-font-size-base.

Best regards @matheuszych

[kergomard]

Hi @catenglaender

I add you as a reviewer to this as there are changes in CSS and I assume we would like to keep the processes introduced by @Amstutz for these changes.

Thank you very much and best, @kergomard

[kergomard]

Hi @thojou

I think you can merge and pick this in the current situation if you have tested this thoroughly. Thanks!

Best, @kergomard

[dsstrassner]

@oliversamoila hey please fast-forward these changes so  this pull request will make it into the release on Tuesday.

[oliversamoila]

Hello everyone, the questions about this PR are mounting. I support the feedback given so far. I also looked at it on a staging platform. Looks good. Stephan already writes 'in the current situation' and, in my mind, he is referring to the vacant CSS authority. I see that too. But I also see the specific problem. So I'm okay with it. If a different solution is up for discussion when the authorities are filled at a later date, we will have to look at it. At the moment, I believe the progress weighs more heavily.

Thanks to all contributors. Best regards, @oliversamoila

[thojou]

Hey @matheuszych,

thanks for the PR. I've integrated the changes into release_9

Best Regards, @thojou