QtPass icon indicating copy to clipboard operation
QtPass copied to clipboard

GnuPG keypair generation takes more than an hour

Open WanEye opened this issue 7 years ago • 7 comments

The window doesn say whether the process is finished or failed or times out. A status message would be convenient.

WanEye avatar Jul 22 '18 11:07 WanEye

There used to be feedback both positive and negative, I'll look into this regression.

annejan avatar Jul 23 '18 08:07 annejan

As to addressing the long key generation times, if compatibility to old gpg versions isn't a huge priority, maybe should use --default-new-key-algo ed25519 for generating keys? ECC keys should require much less randomness and thus be much faster to generate.

rdoeffinger avatar Aug 25 '18 16:08 rdoeffinger

I created a branch with a QFuture usage to handle this key generation so the main process will not stuck. Idk if it can solve but using this i can link the events from Pass to QFuture to control the process

FiloSpaTeam avatar Aug 25 '18 16:08 FiloSpaTeam

I am not sure if it should take this long, for me generating a key even with 3000 bit RSA takes a few seconds at most. However I noticed that QtPass sometimes seems to not notice that the gpg process has exited due to some error and the hangs forever... So do we know for sure it was really gpg taking this long or did it maybe crash or otherwise fail and QtPass fails to handle THAT?

rdoeffinger avatar Aug 25 '18 19:08 rdoeffinger

QtPass calls directly the command so maybe we should use a QProcess or something like that to know who stucks. QFuture or QtConcurrent module can be useful to isolate in another Thread and handle with QObject or events the results and the progress.

FiloSpaTeam avatar Aug 25 '18 20:08 FiloSpaTeam

https://github.com/IJHack/QtPass/pull/640

lherschi avatar Aug 20 '23 20:08 lherschi

This looks fixed as far as I can tell; please close.

wxl avatar Apr 05 '24 22:04 wxl