ingress-intel-total-conversion icon indicating copy to clipboard operation
ingress-intel-total-conversion copied to clipboard

IITC-Mobile: Mobile pane API

Open le-jeu opened this issue 3 years ago • 7 comments

following #220 idea

I'm going to replace this with more simple and straightforward API, involving single call. Like this:

addMobilePane(id,title,icon,onFocus)

where onFocus is function that should return html element to show.

That's all. No need to handle anything. No need in special css (in most cases).

le-jeu avatar May 11 '21 13:05 le-jeu

Currently 'icon' is just mobile resource identifier, which could be enough for standard plugins, but very limiting for any 3rd-party ones.

I wonder if it possible to use icons not embedded into app.

johnd0e avatar May 12 '21 07:05 johnd0e

Currently 'icon' is just mobile resource identifier, which could be enough for standard plugins, but very limiting for any 3rd-party ones.

I wonder if it possible to use icons not embedded into app.

I don't know how hard it is for us to implement, but yes, we can pass the icon from the plugin as a blob. However, there will inevitably be problems with this in the future:

  • Such icons will not be optimized for different screen sizes
  • plugin developers are rarely designers, and therefore will tend to use icons that are out of style
  • such icons will not support a dark/light theme.

For this reason I propose to use only Material icons.

modos189 avatar May 14 '21 08:05 modos189

  • Such icons will not be optimized for different screen sizes

SVG

  • plugin developers are rarely designers, and therefore will tend to use icons that are out of style

Then we will blame them

For this reason I propose to use only Material icons.

But embedded set of icons is extremely limited.

johnd0e avatar May 14 '21 08:05 johnd0e

I think Material icons are enough, but ok, we can consider using svg icons

modos189 avatar May 14 '21 09:05 modos189

I think Material icons are enough

I could agree with you if it would possible to request any icon just by it's id, and then IITCm download (and cache) it.

johnd0e avatar May 14 '21 13:05 johnd0e

there is also a proposal to use FA icons. they can be addressed/selected by name have a common style and are available in different formats including SVG

MysticJay avatar May 14 '21 13:05 MysticJay

conflicts!

johnd0e avatar Dec 17 '21 15:12 johnd0e