snowstorm icon indicating copy to clipboard operation
snowstorm copied to clipboard

Implicit ValueSets created via $expand should have a status and a timestamp

Open Sebge opened this issue 3 years ago • 2 comments

Hey everyone,

while using the Snowstorm to execute an ECL-Query via the $expand-Operation (e.g. http://localhost:8080/fhir/ValueSet/$expand?url=http://snomed.info/sct?fhir_vs=ecl/%3E%3E46621007), the returned implicit ValueSet does not contain a status field. As this is mandatory according to the FHIR specification (http://hl7.org/fhir/valueset-definitions.html#ValueSet.status), it leads to problems with some FHIR clients. My suggestion would be to set the status to "active", even if it is not permanently stored on the server.

Sebge avatar Sep 02 '22 10:09 Sebge

That's great spotting/advice there @Sebge, thank you. I'll raise an internal ticket for that ( see MAINT-2042 ) and it should get into our production system for 19 October and be merged to the master branch not long after that. I'll mark it as a bug as we're failing to provide a mandatory field.

pgwilliams avatar Sep 02 '22 11:09 pgwilliams

Thank you @pgwilliams for your quick answer! While you are at it, you can also take a look at the timestamp field, which is required in the expansion in the ValueSet (http://hl7.org/fhir/valueset-definitions.html#ValueSet.expansion.timestamp) and is also missing at the moment... yes, my client library is very strict regarding absent values 😄

Sebge avatar Sep 02 '22 11:09 Sebge

@Sebge the ValueSet expand status and expansion.timestamp fields have been included in the new FHIR implementation in Snowstorm version 8.1.0 https://github.com/IHTSDO/snowstorm/releases

kaicode avatar Mar 23 '23 14:03 kaicode