sct-snapshot-rest-api icon indicating copy to clipboard operation
sct-snapshot-rest-api copied to clipboard

Published 20 hours ago • verified publisher icon IHTSDO

snomed.js

Open mike11339 opened this issue 6 years ago • 1 comments

In Script snomed.js, on the line 103:

if (rel.active == true && (rel.type.conceptId == 116680003 || rel.type.conceptId == "116680003")) {

why repeats rel.type.conceptId==116680003?

mike11339 avatar Feb 16 '18 18:02 mike11339

Hi @3mlifamily, You are right that in JavaScript is it not necessary to make type safe comparisons. 2 + 3 == 5 equals true. 2 + 3 == "5" also equals true. This could be fixed as a minor code improvement.

kaicode avatar Mar 01 '18 11:03 kaicode