DSG-Net icon indicating copy to clipboard operation
DSG-Net copied to clipboard

[Bug: datav1.py] The loaded semantic labels are bugged

Open GregorKobsik opened this issue 2 years ago • 0 comments

Description:

I suppose, that the code in datav1.py has a bug in line 572. The returned semantic labels are a concatenation of all parent node labels down to the leaf node. This results in errors in the visualization script vis_pc.ipynb, especially in vis_utils.py in function draw_partnet_objects(...) in line 240 color = sem_colors[part_sems[jj]

Solution:

https://github.com/IGLICT/DSG-Net/blob/6c6d117525686fcca14b3efe477dfdb37737b55a/code/datav1.py#L572

You can fix it by replacing the code with: node.full_label = node.label

Example (Object #2197):

Current output

['chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_base/chair/chair_base/foot_base/chair/chair_base/foot_base/foot', 'chair/chair/chair_seat/chair/chair_seat/seat_surface/chair/chair_seat/seat_surface/seat_single_surface', 'chair/chair/chair_seat/chair/chair_seat/seat_support', 'chair/chair/chair_arm/chair/chair_arm/arm_sofa_style', 'chair/chair/chair_arm/chair/chair_arm/arm_sofa_style', 'chair/chair/chair_back/chair/chair_back/back_surface/chair/chair_back/back_surface/back_single_surface', 'chair/chair/chair_back/chair/chair_back/back_surface/chair/chair_back/back_surface/back_single_surface', 'chair/chair/chair_back/chair/chair_back/back_support']

Expected output (after fix)

['chair/chair_base/foot_base/foot', 'chair/chair_base/foot_base/foot', 'chair/chair_base/foot_base/foot', 'chair/chair_base/foot_base/foot', 'chair/chair_seat/seat_surface/seat_single_surface', 'chair/chair_seat/seat_support', 'chair/chair_arm/arm_sofa_style', 'chair/chair_arm/arm_sofa_style', 'chair/chair_back/back_surface/back_single_surface', 'chair/chair_back/back_surface/back_single_surface', 'chair/chair_back/back_support']

Can anyone confirm this bug, too?

GregorKobsik avatar Mar 29 '23 10:03 GregorKobsik