iets3.opensource icon indicating copy to clipboard operation
iets3.opensource copied to clipboard

correction and newly added SI unit libs

Open yonghui-git opened this issue 10 months ago • 2 comments

Minor corrections in the existing unit libs (SIUnits & SIUnitsDerivedAndScaled) and a new lib (SIUnitsDerivedAndScaledWithSpecialNames)

The newly added unit library "" is based on the units from the International System of Units on wikipedia https://en.wikipedia.org/wiki/International_System_of_Units.

Hopefully, all units mentioned by this wikipedia page are covered by these three libraries, i.e., SIUnits, SIUnitsDerivedAndScaled and SIUnitsDerivedAndScaledWithSpecialNames.

yonghui-git avatar Apr 12 '24 14:04 yonghui-git

Hi @yonghui-git ! You should target the maintenance branch, instead of master. Also, you should not migrate the version you use to a newer one.

For choosing the target version, I suggest you using the oldest "supported" maintenance branch of your interest. For instance: the oldest supported maintenance branch is maintenance/mps20213. If you want to see your changes only starting from 2022.2, then you want to choose 2022.2.

In this case (Assuming you want to see your changes only starting from 2022.2), I'd suggest you:

  • start with your change (with no migration) from maintenance/mps20222
  • target your PR to be merged on maintenance/mps20222

psuzzi avatar Apr 16 '24 13:04 psuzzi

Hi @yonghui-git ! You should target the maintenance branch, instead of master. Also, you should not migrate the version you use to a newer one.

For choosing the target version, I suggest you using the oldest "supported" maintenance branch of your interest. For instance: the oldest supported maintenance branch is maintenance/mps20213. If you want to see your changes only starting from 2022.2, then you want to choose 2022.2.

In this case (Assuming you want to see your changes only starting from 2022.2), I'd suggest you:

  • start with your change (with no migration) from maintenance/mps20222
  • target your PR to be merged on maintenance/mps20222

Thanks for reviewing the PR and giving the feedback. I will find time to address your comments.

yonghui-git avatar Apr 17 '24 06:04 yonghui-git