iets3.opensource icon indicating copy to clipboard operation
iets3.opensource copied to clipboard

Published 20 hours ago • verified publisher icon IETS3

CoordCellRef: Fix adding the optional finder

Open alexanderpann opened this issue 2 years ago • 8 comments

This PR replaces the not working optional finder cell of the CoordCellRef editor with a transformation menu so that the finder can be added through the code completion menu of the cell instead of typing "/" before the cell. I changed it because I couldn't get the optional cell working. The missing spaces in the editor (punctuation-x: true) prevent the side transformation to be executed. Fixes #559.

alexanderpann avatar Jun 28 '22 11:06 alexanderpann

@alexanderpann and @sergej-koscejev Thanks very much for the fix. I tried it and it works great. Should we create an issue for the broken optional cell in the grammar cells language? I don't know where that language is or know much about it but I heard it is something useful I should be using. Is it also part of iets3.opensource?

brucetrask avatar Jun 28 '22 11:06 brucetrask

@alexanderpann and @sergej-koscejev Thanks very much for the fix. I tried it and it works great. Should we create an issue for the broken optional cell in the grammar cells language? I don't know where that language is or know much about it but I heard it is something useful I should be using. Is it also part of iets3.opensource?

Actually, the old behavior of the optional cell was wrong, which was fixed a while ago. The way the cell was used is just not compatible with the latest version of grammar cells. There is nothing else that needs to be fixed.

alexanderpann avatar Jun 28 '22 12:06 alexanderpann

@alexanderpann and @sergej-koscejev Ok. Thanks. One last follow up just to make sure I am understanding (I am a bit new to MPS). So, could I use the optional grammar cell facility in this sheets use case or is it that use case which is not compatible with the grammar cells I have with 2021.1? In other words, you mentioned you couldn't get the optional cell working in your comment above. Is that because the use in the sheets is not possible or something else? Just wanted to understand.

brucetrask avatar Jun 28 '22 12:06 brucetrask

The optional cell uses side transformations. Normally they work, but this editor uses punctuation-left:true and punctuation-right:true in some cells which disallows the cursor at those positions. As a result, the side transformations can't be executed because you are not allowed to enter the triggering text (in this case: "/").

alexanderpann avatar Jun 28 '22 13:06 alexanderpann

Thanks @alexanderpann . Appreciate your help on this.

brucetrask avatar Jun 28 '22 13:06 brucetrask

@alexanderpann I am not sure here. Where the questions/findings of @wsafonov already addressed in this PR or are they missing?

arimer avatar Feb 13 '23 14:02 arimer

IMO, I've addressed all points.

alexanderpann avatar Feb 13 '23 15:02 alexanderpann

@arimer I've rebased the PR for 2021.3. It could be merged.

alexanderpann avatar Mar 10 '24 16:03 alexanderpann