playing-with-numbers-node icon indicating copy to clipboard operation
playing-with-numbers-node copied to clipboard

Published 20 hours ago • verified publisher icon IEEE-VIT

Add /triplets route and tests

Open agent515 opened this issue 5 years ago • 4 comments
trafficstars

Issue #76 Added /triplets endpoint and also tests for the same.

Please review this PR and if you're satisfied put hacktoberfest-accepted label on it. : )

agent515 avatar Oct 06 '20 19:10 agent515

Please review this PR @ZiyanK and if found okay, put a hacktoberfest-accepted label on it. Thanks.

agent515 avatar Oct 09 '20 07:10 agent515

Route doesn't seem to be working. Kindly fix it.

ZiyanK avatar Oct 11 '20 06:10 ZiyanK

@ZiyanK body = { "sides": [3, 4, 5] } is the valid body.

I'm sorry because I didn't change it in the docstring of the endpoint. I'll push those changes now. Can you check again with this request body?

agent515 avatar Oct 11 '20 07:10 agent515

@ZiyanK Refer test cases to test the endpoint.. I've tested API on Postman and npm run test passes all the testcases

agent515 avatar Oct 15 '20 15:10 agent515