idux icon indicating copy to clipboard operation
idux copied to clipboard

fix(comp:tree): searchKeys is affected by the side effects of other v…

Open liuzaijiang opened this issue 2 years ago • 2 comments

…ariables

fix #1462

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines
  • [ ] Tests for the changes have been added/updated or not needed
  • [ ] Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

此issue中的demo由于设置了动态disabled,导致修改到了mergedNodeMap.value值,而searchKeyscomputed中被mergedNodeMap.value收集到了依赖,所以更新了searchKeys,进而影响到了expandedKeys; 所以把computed改为watch,使得searchKeys仅被props.searchValue影响

Other information

liuzaijiang avatar Mar 03 '23 08:03 liuzaijiang

This preview will be available after the AzureCI is passed.

idux-bot[bot] avatar Mar 03 '23 08:03 idux-bot[bot]

Codecov Report

Merging #1483 (b9382af) into main (82ce25b) will not change coverage. The diff coverage is n/a.

:exclamation: Current head b9382af differs from pull request most recent head 0da4641. Consider uploading reports for the commit 0da4641 to get more accurate results

@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files         331      331           
  Lines       30661    30661           
  Branches     3527     3527           
=======================================
  Hits        28454    28454           
  Misses       2207     2207           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Mar 03 '23 09:03 codecov[bot]