acre2 icon indicating copy to clipboard operation
acre2 copied to clipboard

Add 'acre_api_fnc_getRadioOnOffState' to accessible method

Open gerard-sog opened this issue 1 year ago • 4 comments

When merged this pull request will:

  • Describe what this pull request will do:

Add 'acre_api_fnc_getRadioOnOffState' to accessible method.

gerard-sog avatar Aug 20 '24 16:08 gerard-sog

  • The two functions you have in PR don't add any behavior.
  • Adding a wrapper isn't going to magically make it work.

Need to check how GetVolume works and add necessary logic I think. (comments from people in Discord ACE : https://discord.com/channels/976165959041679380/976228128156446731/1275560027289026673)

gerard-sog avatar Aug 20 '24 21:08 gerard-sog

getRadioOnOffState seems like a very clunky name to me, maybe something like getPowerState would be better?

Drofseh avatar Aug 21 '24 01:08 Drofseh

getRadioOnOffState seems like a very clunky name to me, maybe something like getPowerState would be better?

I don't think so since getRadioOnOffState already exists and changing the name to getPowerState would be a good idea if I also renamed all previous references to the old name then. Which is too much of a hassle for too little gain.

gerard-sog avatar Aug 21 '24 12:08 gerard-sog

Ahh fair enough

Drofseh avatar Aug 21 '24 15:08 Drofseh