idaes-pse
idaes-pse copied to clipboard
Update grid integration
Fixes
model_data.py
: Model data classes for thermal and renewable generators
bidder.py
: Assemble thermal vs renewable bids; also some activating and deactivation of day_ahead_power_ub
. Not sure what the intention for this was...
Summary/Motivation:
These are the final set of changes to the updated grid integration code for the DA + RT bidding with different generator types. The previous PRs are #855 and #870
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
- I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
- I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
Is this generalized or does it fix an immediate need for DISPATCHES? Xian was working on a similar feature. I am curious how this relates to his work.
-- Alexander Dowling, Ph.D. Assistant Professor Chemical and Biomolecular Engineering (primary) Applied & Computational Mathematics & Statistics (concurrent) University of Notre Dame
Office: 369 Nieuwland Hall, Notre Dame, IN, 46556-5670 Phone: 574-631-4041 Email: @., @. Website: www.dowlinglab.org
This PR contains the remaining changes that haven't been merged from Xian's branch into idaes with #855 and #870
Well, these changes are the final ones from Xian's branch at the date when the double loop notebooks for the RE case with RT and DA bidding was implemented. Xian may have added new things in other branches that do grid updates that are not included in here.
This PR is needed to run the RE double loop notebook and the NE and FE ones as they have updated to use the updated grid integration code. https://github.com/gmlc-dispatches/dispatches/issues/154
Codecov Report
Base: 70.04% // Head: 70.06% // Increases project coverage by +0.01%
:tada:
Coverage data is based on head (
73b8961
) compared to base (20ac4f6
). Patch coverage: 95.04% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 70.04% 70.06% +0.01%
==========================================
Files 400 400
Lines 66272 66323 +51
Branches 12201 12216 +15
==========================================
+ Hits 46420 46468 +48
- Misses 17480 17482 +2
- Partials 2372 2373 +1
Impacted Files | Coverage Δ | |
---|---|---|
idaes/apps/grid_integration/forecaster.py | 86.82% <0.00%> (+0.66%) |
:arrow_up: |
idaes/apps/grid_integration/coordinator.py | 97.15% <81.81%> (-0.37%) |
:arrow_down: |
idaes/apps/grid_integration/bidder.py | 94.39% <90.47%> (-0.39%) |
:arrow_down: |
...pps/grid_integration/examples/thermal_generator.py | 66.07% <100.00%> (ø) |
|
idaes/apps/grid_integration/model_data.py | 94.81% <100.00%> (+1.17%) |
:arrow_up: |
idaes/apps/grid_integration/tracker.py | 100.00% <100.00%> (ø) |
|
idaes/ver.py | 61.53% <0.00%> (-4.62%) |
:arrow_down: |
idaes/apps/matopt/materials/atom.py | 75.75% <0.00%> (+6.06%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@radhakrishnatg @adowling2 @Xinhe-Chen @bknueven Tests are passing, and this is ready for a review :)
As part of gmlc-dispatches/dispatches/issues/148, I've added Xian's code for relaxed_day_ahead_power_ub
and real_time_underbid_power[t]
. These changes allow the bidder to take a penalty for submitting a RT bid that's less than the accepted DA bid, rather than it being a hard constraint.
There's also an additional change where the deviation_penalty during tracking is no longer a single number, but is high during tracking hours and lower in subsequent hours.
Thanks @bknueven for the review!
Doc strings and tests added-- ready for re-review @adowling2
@radhakrishnatg I don't think you'll need to make any changes to the NE double loop notebook. 🤞