idaes-pse
idaes-pse copied to clipboard
Correction to the MEA solvent property package and column
Fixes
MEA_solvent property package and solvent_column unit model
Summary/Motivation:
Corrections to the molar enthalpy calculation and MEA enthalpy of vaporization in the MEA_solvent property package, along with the enthalpy transfer term in solvent_column unit model
Changes proposed in this PR:
- Converting the temperature used in the molar enthalpy calculation for liquid phase components, from K to deg C
- Including the value for MEA enthalpy of vaporization to ensure accurate molar enthalpy calculation
- Correcting the enthalpy transfer term in solvent_column unit model
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
- I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
- I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
@anujad95 is this ready for a re-review?
Yes, this is ready for a re-review. We are waiting for some more changes in the MEAsolvent_column file, in terms of model reformulation, after which this will be ready for a final review.
@anujad95 There are a lot of failing tests in this PR which need to be fixed before we can review it. You should also update the branch as well.
I've updated this branch from main in hopes that this can be merge in time for the Aug release (meaning next week).
Codecov Report
Merging #914 (512b686) into main (3de93b1) will decrease coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #914 +/- ##
==========================================
- Coverage 70.32% 70.32% -0.01%
==========================================
Files 576 576
Lines 64619 64618 -1
Branches 12138 12138
==========================================
- Hits 45446 45444 -2
- Misses 16872 16875 +3
+ Partials 2301 2299 -2
Impacted Files | Coverage Δ | |
---|---|---|
...es/models_extra/column_models/MEAsolvent_column.py | 97.32% <ø> (ø) |
|
...dels_extra/column_models/properties/MEA_solvent.py | 98.76% <100.00%> (ø) |
|
idaes/models_extra/column_models/solvent_column.py | 91.25% <100.00%> (-0.04%) |
:arrow_down: |
idaes/ver.py | 61.53% <0.00%> (-4.62%) |
:arrow_down: |
...erties/modular_properties/base/generic_property.py | 64.03% <0.00%> (+0.10%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.