idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Enable macOS runners in CI workflows

Open lbianchi-lbl opened this issue 2 years ago • 3 comments

Summary/Motivation:

  • Add macOS runners to GHA job matrix to see how much of the test suite is supported

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

lbianchi-lbl avatar Jun 16 '22 21:06 lbianchi-lbl

Codecov Report

Merging #895 (99fbdd5) into main (5657571) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   70.06%   70.06%   -0.01%     
==========================================
  Files         573      573              
  Lines       63981    63981              
  Branches    12046    12046              
==========================================
- Hits        44829    44826       -3     
- Misses      16866    16870       +4     
+ Partials     2286     2285       -1     
Impacted Files Coverage Δ
idaes/ver.py 61.53% <0.00%> (-4.62%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jun 16 '22 23:06 codecov[bot]

@lbianchi-lbl is working on this

ksbeattie avatar Aug 04 '22 18:08 ksbeattie

This is some good news: https://github.blog/changelog/2022-08-09-github-actions-self-hosted-runners-now-support-apple-m1-hardware/

ksbeattie avatar Aug 11 '22 18:08 ksbeattie

Since we have everything but HSL, maybe we can just tag the tests that require HSL and not run them for Intel macOS? I think 62 fail, but including integration (I think). https://github.com/IDAES/idaes-ext/actions/runs/4244093378/jobs/7377718944

eslickj avatar Mar 09 '23 20:03 eslickj

This approach is not needed anymore since we now have actual (albeit HSL-less) idaes-ext builds for macOS x86_64. We'll close this and open a new PR adding macOS to GHA without the conda-forge Ipopt workaround.

lbianchi-lbl avatar Mar 16 '23 18:03 lbianchi-lbl