idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Allowing user to make the server global

Open elbashandy opened this issue 2 years ago • 1 comments

Fixes

Addresses #868

Summary/Motivation:

The user should be able to specify if the server should run as a localhost or as 0.0.0.0

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

elbashandy avatar May 20 '22 23:05 elbashandy

Codecov Report

Merging #875 (570e0f9) into main (f0e136f) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
- Coverage   70.07%   70.06%   -0.01%     
==========================================
  Files         573      573              
  Lines       64007    64011       +4     
  Branches    12053    12053              
==========================================
+ Hits        44850    44851       +1     
- Misses      16868    16872       +4     
+ Partials     2289     2288       -1     
Impacted Files Coverage Δ
idaes/core/ui/fsvis/fsvis.py 89.28% <100.00%> (ø)
idaes/core/ui/fsvis/model_server.py 90.14% <100.00%> (+0.18%) :arrow_up:
idaes/ver.py 61.53% <0.00%> (-4.62%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 06 '22 00:07 codecov[bot]

Closing this as we intend to revisit the server infrastructure part for compatibility with hosted Jupyter environments (e.g. Binder).

lbianchi-lbl avatar Sep 22 '22 18:09 lbianchi-lbl