idaes-pse
idaes-pse copied to clipboard
Gaslib gas distribution model parsing tools
Fixes
NA
Summary/Motivation:
This PR integrates work done to expand the capabilities in idaes.models_extra.gas_distribution. Included are two files that allow for the parsing and conversion of Gaslib network and scenario files to create idaes models.
Changes proposed in this PR:
- Addition of gaslib_parser which adds capabilities to read Gaslib XML files
- Addition of network_data which takes networks read by gaslib_parser and creates an idaes model for the network
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
- I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
- I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
Codecov Report
Merging #837 (8d008d0) into main (33ef91c) will increase coverage by
0.11%
. The diff coverage is80.36%
.
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 68.01% 68.12% +0.11%
==========================================
Files 569 571 +2
Lines 62415 63016 +601
Branches 11535 11631 +96
==========================================
+ Hits 42452 42932 +480
- Misses 17783 17874 +91
- Partials 2180 2210 +30
Impacted Files | Coverage Δ | |
---|---|---|
...models_extra/gas_distribution/data/network_data.py | 79.24% <79.24%> (ø) |
|
...ls_extra/gas_distribution/parsers/gaslib_parser.py | 83.78% <83.78%> (ø) |
|
idaes/ver.py | 61.53% <0.00%> (-4.62%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 33ef91c...8d008d0. Read the comment docs.
@joshuahaddad I've put this on the Aug release and added a few reviewers. Let me know if that's not correct.
@joshuahaddad, @Robbybp any update on this? Moving to the November release board...
@joshuahaddad, @Robbybp any update on this? Moving to the November release board...
Hey Keith, I left Sandia around this time and handed progress off to Michael. When I get home today I can submit the style changes when I get home today if needed. However, I don’t have a system that can run the code (needed a Linux optimizer build I believe).
@Robbybp, @michaelbynum is this something you can take over?
@ksbeattie @michaelbynum I believe we can close this PR. These are useful tools that we would like to have if we were to continue working on pipeline models, but I don't believe anybody is doing this actively.
I will pick this up in early October.
@michaelbynum Any update on this PR? I am looking over our backlog of stale PRs to see what can/should be closed as inactive.
I am going to get this done, but it is going to be a while. Let's close it until I can get back to it.