idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

Need to increase number of verification tests

Open andrewlee94 opened this issue 4 years ago • 3 comments

We need to include more model verification tests across a range of use cases. Currently testing of dynamic cases is rather sparse.

andrewlee94 avatar Jan 21 '21 20:01 andrewlee94

Yeah. It would be really nice if we had a source of models with known results. I was hoping to find some simple test set for the PID controller testing, but haven't yet.

eslickj avatar Jan 21 '21 20:01 eslickj

@andrewlee94 What do you mean by model verification? Testing that use cases work from a software/tractability perspective, or that they give us the results we expect (possibly by comparing with external results)?

Robbybp avatar Jan 26 '21 19:01 Robbybp

@Robbybp In reality, both. We need to test more case studies to look for any bugs or edge-cases in the code and also to verify the model results against known sources.

andrewlee94 avatar Jan 26 '21 19:01 andrewlee94