idaes-pse icon indicating copy to clipboard operation
idaes-pse copied to clipboard

PriceTaker Model Checklist

Open adam-a-a opened this issue 7 months ago • 4 comments

The PriceTaker class must still be merged into the main codebase. This class and associated workflow can be useful for projects related to DISPATCHES-type work. For example, modeling flexible desalination in WaterTAP is of interest, and we could make use of the Pricetaker class.

Here is a to-do list based on @andrewlee94 's suggested changes and @radhakrishnatg 's suggestions for enhancement.

**Finish PR #1358 **

  • [x] Add technical reference for Pricetaker class @MarcusHolly #1358
  • [ ] Add demo/tutorial/how-to on Pricetaker class usage via an example @MarcusHolly @radhakrishnatg
  • [ ] Add test file for design_and_operation_model.py @radhakrishnatg
  • [ ] Strengthen unit tests across the board (e.g., test add_startup_shutdown and other methods); consider simpler dummy cases for unit testing all the methods in isolation @adam-a-a

Create new PR(s) for the following

  • [ ] Enable addition of startup, shutdown, ramping, etc. constraints when representative days (as opposed to full-year price signal) are used
  • [ ] Enable addition of cash flow/cost expressions when representative days are used
  • [ ] consider testing with IDAES process model (beyond simplified surrogate models that don't use typical IDAES unit models)
  • [ ] allow for different temporal resolution; cashflow calcs limited to hourly

adam-a-a avatar Jul 09 '24 17:07 adam-a-a