idaes-pse
idaes-pse copied to clipboard
Renewable + PEM Parameterized Bidder
Fixes
Add the renewable+PEM parameterized bidder (bids the power at a constant price).
Summary/Motivation:
- Add a PerfectForecaster to predict the day-ahead and real-time wind power and electricity prices (if needed).
- Add a PEMParameterizedd bidder to bid the renewable power at a constant prices.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
- I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
- I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
Also, we will need documentation for the new classes and how to use them.
Also, we will need documentation for the new classes and how to use them.
Thank you for your comments! I am still working on improving the tests. The documentation will be added in this PR https://github.com/IDAES/idaes-pse/pull/1090.
@radhakrishnatg Hi Radhakrishna, would you please review this PR? Thank you!
@adowling2 this is ready for review.
Codecov Report
Attention: Patch coverage is 83.85093%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 76.37%. Comparing base (
94a3043
) to head (c22317a
).
Files | Patch % | Lines |
---|---|---|
idaes/apps/grid_integration/bidder.py | 87.50% | 15 Missing and 1 partial :warning: |
idaes/apps/grid_integration/forecaster.py | 69.69% | 8 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1407 +/- ##
==========================================
+ Coverage 76.36% 76.37% +0.01%
==========================================
Files 394 394
Lines 64953 65108 +155
Branches 14404 14423 +19
==========================================
+ Hits 49601 49729 +128
- Misses 12793 12818 +25
- Partials 2559 2561 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Xinhe-Chen any news on this?
@Xinhe-Chen any news on this?
I will request a review from Prof. Dowling again.
Tag other people too
@dguittet Hi Darice, I created this PR to merge the renewable-parameterized bidder code in dispatches into IDAES, would you mind reviewing it? Thank you!
@adowling2 This is ready for review.
@ksbeattie Hi Keith, we hope to have this PR reviewed and merged next week.
@Xinhe-Chen, please reply to the open comments to confirm these were addressed.
Hi Prof. Dowling, I addressed all comments from you last Friday.
I am going to to a final check later today to ensure no other issues are remaining later today.
Excellent. Tag me here when it is ready to review.
Excellent. Tag me here when it is ready to review.
@adowling2 This is ready for review.
@andrewlee94 Hi Andrew, I think I have already addressed your comments. Shall we get this PR merged?
Sorry for the delay, I was at a conference or out on leave the past three weeks. A couple of minor requests for changes to how you are using the logger.
Thank you! I have addressed your new comments.