idaes-pse
idaes-pse copied to clipboard
Adding initial support for v2 solvers
First part of new scaling
Summary/Motivation:
This PR adds the first infrastructure to allow us to test the new IPOPT infterface using get_solver
. For now, scaling is turned off as we expect this to cause issues, and we will first switch to using ipopt_v2 with only the presolve.
Changes proposed in this PR:
- Add ipopt_v2 default options to the IDAES config
- Add logic to the IDAES SolverWrapper to handle v2 solvers
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
- I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
- I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
Codecov Report
Attention: Patch coverage is 86.66667%
with 4 lines
in your changes are missing coverage. Please review.
:exclamation: No coverage uploaded for pull request base (
scaling_v2@88553c1
). Click here to learn what that means.
Files | Patch % | Lines |
---|---|---|
idaes/core/solvers/config.py | 50.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## scaling_v2 #1384 +/- ##
=============================================
Coverage ? 77.58%
=============================================
Files ? 391
Lines ? 64398
Branches ? 14266
=============================================
Hits ? 49963
Misses ? 11851
Partials ? 2584
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing this as it is out of date and will be replaced by a new PR that also selectively activates the new presolver.