Inflector icon indicating copy to clipboard operation
Inflector copied to clipboard

Add more irregular words

Open hkdobrev opened this issue 7 years ago • 4 comments

Any help with the tests is appreciated!

hkdobrev avatar Aug 25 '17 11:08 hkdobrev

Thanks for your contribution! I left a comment, it should fix the issues. I'm in an hackathon until Saturday. If the problem persist I'll have a look next week.

olvlvl avatar Aug 25 '17 14:08 olvlvl

@olvlvl I don't get why this

	->singular('/^are$/i`', 'is')
	->singular('/^were$/i`', 'was')
	->singular('/^have$/i`', 'has')

would break the tests as I have added ^ and $. Am I missing something? I suspect there could be a deeper issue behind this.

hkdobrev avatar Aug 31 '17 07:08 hkdobrev

Please rebase.

olvlvl avatar Aug 31 '17 08:08 olvlvl

Please rebase.

✅ Done.

hkdobrev avatar Aug 31 '17 08:08 hkdobrev