quality-time icon indicating copy to clipboard operation
quality-time copied to clipboard

Report as PDF shows error report doesn't exist

Open wkoot opened this issue 2 years ago • 0 comments

Describe the bug Download report as PDF returns a PDF with the error "Sorry, this report doesn't exist", for tag "test quality". Suspect that this has to do with the space in the tag, because tags without spaces work as expected.

To Reproduce Steps to reproduce the behaviour:

  1. Go to a report for a tag which includes a space
  2. Click on "Download report as PDF"
  3. View the downloaded PDF
  4. See error

Expected behaviour A clear and concise description of what you expected to happen.

Renderer logs

URL http://www:80/tag-test quality?report_url=https%3A%2F%2Fquality-time.test%2Ftag-test%2520quality: opened
URL http://www:80/tag-test quality?report_url=https%3A%2F%2Fquality-time.test%2Ftag-test%2520quality: spinner hidden
URL http://www:80/tag-test quality?report_url=https%3A%2F%2Fquality-time.test%2Ftag-test%2520quality: PDF created

Interestingly, note how the second space is actually urlencoded twice; " " => "%20" => "%2520"

Your environment (please complete the following information):

  • Docker swarm
  • Browser Firefox 106.0.1
  • Quality-time version v4.3.0

wkoot avatar Oct 26 '22 11:10 wkoot