quality-time icon indicating copy to clipboard operation
quality-time copied to clipboard

Allow for filtering out specific measurement entities though regular expressions

Open Sebastiaan127001 opened this issue 3 years ago • 5 comments

This feature already exists for OWASP sources, I believe, but it would also be useful for other sources like AXE core.

For example, AXE core has limitations and therefore generates false positives. Some tools cannot be configured properly to remove these violations. In those cases, it would be useful to manage this in QT. That is the added value of QT.

Add two fields:

  • Entities to include (regex)
  • Entities to exclude (regex)

Add a possibility to the data model to exclude entity attributes from matching.

Implement a generic matcher in the base collector.

Note: Order of including/excluding doesn't matter, explain this in the UI somewhere.

We first need to refactor the collector to allow for filtering entities by regular expression in one location (in the base SourceCollector): #4714.

Sebastiaan127001 avatar Jan 27 '22 14:01 Sebastiaan127001

this would also come in handy when reviewing individual SonarQube violations. Sometimes the team has decided that they won't fix violations of a certain kind or they don't see it as an issue.

Sebastiaan127001 avatar Feb 01 '22 16:02 Sebastiaan127001

At least at first, we're not going to implement a generic solution, so we need to know which sources and which attributes you need to filter on. If we read your request correctly, you need:

  • SonarQube, violations metric, suppress by "message"
  • Axe, accessibility violations metric, suppress by "violation type"

Correct?

fniessink avatar Mar 02 '22 15:03 fniessink

for now, yes

Sebastiaan127001 avatar Mar 02 '22 15:03 Sebastiaan127001

image

The above example shows that the issues reappearing.

Sebastiaan127001 avatar May 18 '22 13:05 Sebastiaan127001

%VOTE

Sebastiaan127001 avatar Sep 13 '22 08:09 Sebastiaan127001

@fniessink can we combine this with the issues that we have with software versions that do not comply to the standard? Currently, the software version metric reports an error if the version has a postfix. If we can add the regular expression to the source configuration, we might be able to fix this in one go.

Sebastiaan127001 avatar Dec 22 '22 16:12 Sebastiaan127001

@Sebastiaan127001 can you make separate issues for changes to the SonarQube and software_versions metrics, if this is still applicable?

wkoot avatar Apr 12 '23 20:04 wkoot