parsec icon indicating copy to clipboard operation
parsec copied to clipboard

Issue parsec_fatal when the datatype_arenas have not been set in the PTG

Open abouteiller opened this issue 9 months ago • 4 comments

Issue parsec_fatal when the datatype_arenas have not been set (rather than crashing in a cryptic way), examplified by icldisco/dplasma#138

abouteiller avatar Mar 12 '25 14:03 abouteiller

We got a datatype with a count non-zero and no datatype, that should not exist

abouteiller avatar Mar 12 '25 17:03 abouteiller

It should not matter until the end of the iterator. We don't have to police every dep type, only that the end we have one.

bosilca avatar Mar 12 '25 17:03 bosilca

Is it ever valid to have a non-zero count with an invalid datatype? How? Otherwise this error seems legit.

devreal avatar Mar 27 '25 14:03 devreal

Define valid in this particular context ? From the communication perspective it is invalid to have a non-zero count with an invalid datatype, but the communication is bound to a flow in the receive case not to any particular deps inside the flow. This PR checks for each dep, even the ones that will not finally be associated with the communication, instead of checking only once at the end to make sure the flow (and therefore the communication to be issued) is correct.

bosilca avatar Mar 28 '25 18:03 bosilca