parsec icon indicating copy to clipboard operation
parsec copied to clipboard

Inconsistent function name in RECURSIVE

Open QingleiCao opened this issue 2 years ago • 6 comments

Describe the bug

The first issue: DPLASMA_WITH_RECURSIVE and PARSEC_HAVE_RECURSIVE are independent; which means PARSEC_HAVE_RECURSIVE is always OFF by default even if DPLASMA_WITH_RECURSIVE is ON.

The second issue: if PARSEC_HAVE_RECURSIVE is enabled manually, DPLASMA can not compile with the following error:

/home/qcao3/dplasma/build/src/dpotrf_L.c:3960:32: error: 'hook_of_dpotrf_L_potrf_dgemm_recursive' undeclared here (not in a function); did you mean 'hook_of_dpotrf_L_potrf_dgemm_RECURSIVE'?
 3960 |      .hook = (parsec_hook_t *) hook_of_dpotrf_L_potrf_dgemm_recursive},
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                hook_of_dpotrf_L_potrf_dgemm_RECURSIVE

I guess it’s because of this commit

To Reproduce

Steps to reproduce the behavior:

  1. Manually enable PARSEC_HAVE_RECURSIVE
  2. Compile DPLASMA

Expected behavior

Compilation failure

Environment (please complete the following information):

Saturn ICL

Additional context

Add any other context about the problem here. The content of the config.log file can be useful in some cases.

QingleiCao avatar Dec 12 '22 18:12 QingleiCao