pyABC icon indicating copy to clipboard operation
pyABC copied to clipboard

Fix minor bug in petab importer

Open arrjon opened this issue 1 year ago • 1 comments

The Petab importer also generates an Amici model, which requires adapting parameter scales. However, a small bug occurred due to passing the entire dictionary to the rescale function instead of just the specific dictionary value. This resulted in failure during simulation.

arrjon avatar Apr 11 '24 11:04 arrjon

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.32%. Comparing base (ef02bbb) to head (d486ede). Report is 29 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #636      +/-   ##
===========================================
- Coverage    86.73%   84.32%   -2.42%     
===========================================
  Files          139      141       +2     
  Lines         7941     8535     +594     
===========================================
+ Hits          6888     7197     +309     
- Misses        1053     1338     +285     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 11 '24 11:04 codecov-commenter