equal-access icon indicating copy to clipboard operation
equal-access copied to clipboard

Ensure Active messages explain what is wrong in all contexts of the message: Checker Help, reports, Karma, Cypress, etc. #3694

Open aliunwala opened this issue 3 years ago • 1 comments

The active messages needs to explain what is it that is wrong, not simply what is. Since the active message may also stand by itself, not in context with the passive message as when in the Checker Help view, but when only an active message is displayed in the Reports, Karma, and Cypress results.

Examples: "Text input is nested in label, so label is not before the text input control" vs "Text input is nested in label, so label is [incorrectly] not before the text input control"

"Label text is located after its associated text input or element"

Describe what needs to be accomplished

Update Active messages where appropriate.

  • [ ] Review active messages in Help, Reports, Karma, Cypress, and Node results
  • [ ] Identify candidate active messages needing editing
  • [ ] Edit messages & test cases impacted
  • [ ] Update Checker Help Style Guide

Why does this need to be accomplished

Reduce confusion with messages

Related issues or references

See "Confusing message text and possible false positive for g1017 on file input #237"

Supporting notes and details

All messages are in a single file, making the initial review less ownersome. .../accessibility-checker-engine/src/v2/checker/accessibility/nls/index.ts file However, every messages edited may cause corresponding text cases to also be update in several places.

image

aliunwala avatar Jun 03 '22 22:06 aliunwala

From Triage: We need a review of 150+ messages to see if they are appropriate. And then fix any that look bad.

aliunwala avatar Jun 16 '22 20:06 aliunwala