equal-access icon indicating copy to clipboard operation
equal-access copied to clipboard

Help content update for rules related to ARIA properties

Open shunguoy opened this issue 2 years ago • 6 comments

see details in the box note: https://ibm.ent.box.com/notes/994215482156 also see the rule logic issue: #1034

shunguoy avatar Aug 08 '22 20:08 shunguoy

Need to review existing Help files for the following 3 rules to determine if any Help changes needed

  • [x] Rpt_Aria_ValidProperty:             "group": "ARIA attributes must be valid for the element's role",             "Fail_1": "The attribute(s) '{0}' referenced by the element <{1}> is not a valid ARIA state or property"
  • [x] Rpt_Aria_RequiredProperties:              "group": "When using a ARIA role on an element, the required attributes for that role must be defined",              "Fail_1": "An element with ARIA role '{0}' does not have the required ARIA attribute(s): '{1}'"
  • [x] aria_~~semantics~~_attribute_allowed:                 "group": "ARIA attributes must be valid for the element and ARIA role to which they are assigned",                 "Fail_invalid_role_attribute": "The ARIA attributes '{0}' is not valid for the element <{1}> with ARIA role '{2}'"                 "Fail_2": "The ARIA attributes '{0}' are not valid for the element <{1}> with implied role "none"'                 "Fail_invalid_elem_attribute": "The ARIA attributes '{0}' are not valid for the element <{1}> with implied role '{2}'"

philljenkins avatar Aug 09 '22 00:08 philljenkins

@shunguoy please review my proposed changes to the Help, see secton 7. Help https://ibm.ent.box.com/notes/994215482156

philljenkins avatar Aug 09 '22 20:08 philljenkins

@philljenkins updated for your further refinement. thanks.

shunguoy avatar Aug 10 '22 15:08 shunguoy

@shunguoy which branch should I implement your and my proposed changes?
into the changed ruleID html Help file for aria_attribute_allowed #1034

philljenkins avatar Aug 10 '22 23:08 philljenkins

@philljenkins the branch is dev-563

shunguoy avatar Aug 11 '22 16:08 shunguoy

@philljenkins the branch is dev-563

shunguoy avatar Aug 11 '22 16:08 shunguoy

Implementing Help changes into branch dev-563

philljenkins avatar Aug 16 '22 15:08 philljenkins

@shunguoy Please provide a screen shot of the Help here for review

philljenkins avatar Aug 16 '22 23:08 philljenkins

Help implemented correctly, ready for test when rest of branch is ready image

philljenkins avatar Aug 17 '22 16:08 philljenkins

@philljenkins @shunguoy Please provide a test file path: Screen Shot 2022-09-07 at 6 16 12 PM

ErickRenteria avatar Sep 07 '22 23:09 ErickRenteria

@eirckr the one help test example is https://github.com/IBMa/equal-access/pull/1048/commits/d6a8dfc5bd438bdfc16310795c1396ab26a444e3#diff-455823d79ce8f5be1b5be2f170c5db632a02323b18ef2ffb40e0208776572063

shunguoy avatar Sep 08 '22 19:09 shunguoy