equal-access icon indicating copy to clipboard operation
equal-access copied to clipboard

Validation of Aria attributes for the elements without an explicit role failed

Open shunguoy opened this issue 2 years ago • 1 comments

when an element doesn't have an implicit role, the engine report might contain false positives or negatives.  For example,  the following elements should cause a violation, but we don't report them:                              my label               xxx        <template aria-details="detail">xxx</template>        <var aria-checked="detail">xxx</var>        <script aria-details="detail" aria-checked="detail">xxx</script>        <picture aria-details="detail" aria-checked="detail">xxx</picture>

Per team discussion, the rule "aria_semantics_attribute" should be modified to make the code fix, an additional issue is to open for updating the help content.

  • [ ] code change
  • [ ] test cases
  • [ ] message change
  • [x] help content update #1035

shunguoy avatar Aug 08 '22 20:08 shunguoy

investigate the different cases:

  • [x] neither implicit nor explicit role, Not global attributes either
  • [x] neither implicit nor explicit role, but allow certain specific attributes
  • [x] neither implicit nor explicit role, but allow global attributes
  • [x] no implicit, but allow explicit with/without global and other attributes
  • [x] with implicit but not explicit with or without global or other attributes
  • [x] allow both implicit and explicit roles with or without global or other attributes
  • [?] neither implicit nor allowed explicit role doesn't mean "none | presentation" role, the element can still be mapped over to AT by the browser user agent (such as label, link, legend, caption, map).

shunguoy avatar Aug 12 '22 15:08 shunguoy

updated aria definition, and messages, and added more test cases.

shunguoy avatar Aug 15 '22 14:08 shunguoy

working to modify the existing test cases that failed after the aria updates

shunguoy avatar Aug 15 '22 14:08 shunguoy

encountered an error in opening the help link:

Screen Shot 2022-08-15 at 10 28 54 AM

shunguoy avatar Aug 15 '22 15:08 shunguoy

after the current aria changes, 33 existing test cases failed, which need to be reviewed and updated one by one.

shunguoy avatar Aug 15 '22 20:08 shunguoy

continuing the test cases, help content test, and the baseline updates.

shunguoy avatar Aug 17 '22 14:08 shunguoy

@shunguoy please provide a test file

ErickRenteria avatar Sep 07 '22 23:09 ErickRenteria

Validated

ErickRenteria avatar Sep 09 '22 16:09 ErickRenteria