xmlservice icon indicating copy to clipboard operation
xmlservice copied to clipboard

spawn call overwrites instead of ORs flags

Open NattyNarwhal opened this issue 3 years ago • 1 comments

See: https://github.com/IBM/xmlservice/blob/20800d6be4aa4748b6eb226896c899c9c7e752ab/src/plugipc.rpgle#L1488

It overwrites a mutually exclusive job name flag, but it's also getting rid of the multithreaded job flag. Is this intentional? If so, the previous two lines should be dropped or this turned into an |=?

NattyNarwhal avatar Apr 01 '22 18:04 NattyNarwhal

It seems intentional. The change comment said:

1.9.3 xmlservice change spawn attributes no thread, different name

Previous flags are overwritten. Not sure why leave dead code there. Since XmlService is running under single-threaded job, the setup seems OK.

jimoibm avatar Jun 28 '22 07:06 jimoibm