xmlservice icon indicating copy to clipboard operation
xmlservice copied to clipboard

Migrate PHP tests to PHP toolkit repo

Open kadler opened this issue 6 years ago • 7 comments

While we're converting the existing PHP tests to not use the PHP toolkit in #20, they may be useful to https://github.com/zendtech/IbmiToolkit. We should submit them over there.

kadler avatar Jan 23 '19 20:01 kadler

We would appreciate them and a build server to run them on for CI builds, thanks! ;)

chukShirley avatar Jan 23 '19 21:01 chukShirley

@chukShirley I'm building all the Python tests as unit tests with mocking. Eventually, I'd like some integration tests too, but with mocked unit tests, you can use something like TravisCI which is awesome.

kadler avatar Jan 23 '19 21:01 kadler

Agreed, yes. I was specifically requesting an IBM i partition for running integration tests. It'd be useful for all client toolkits, really. I know this probably isn't the place to make the request, though.

chukShirley avatar Jan 23 '19 21:01 chukShirley

Yep, I agree that's really needed. I'd love something like TravisCI for open source IBM i projects. Maybe Liam can get his barryCI going.

kadler avatar Jan 23 '19 21:01 kadler

Let's pick one test to start with: https://github.com/IBM/xmlservice/blob/master/test/php/test_50100_ibm_db2_io_jvm_ZZJAVA.phpt (RPG Java test)

  • Migrate this PHP Toolkit-dependent test to the https://github.com/zendtech/IbmiToolkit repository
  • If there is no equivalent XMLSERVICE test to this Java one that does not rely on the PHP Toolkit, create one for this XMLSERVICE repository.

alanseiden avatar Jul 08 '22 19:07 alanseiden

Note: There is a second PHP Toolkit - dependent test calling ZZJAVA. https://github.com/IBM/xmlservice/blob/master/test/php/test_50110_ibm_db2_io_jvm_ZZJAVA2.phpt

alanseiden avatar Jul 22 '22 19:07 alanseiden

For reference in creating future tests, here is an XMLSERVICE test that does not need the PHP Toolkit. While written in PHP, it does NOT require the toolkit as a dependency. The test passes XML directly to the XMLSERVICE stored procedures. https://github.com/IBM/xmlservice/blob/master/test/php/test_10120_ZZCALL_ibm_db2_io_pgm.phpt

This test uses the ibm_db2 transport. We could adapt it using the CLI transport to remove database depencency.

alanseiden avatar Jul 22 '22 19:07 alanseiden