unitxt icon indicating copy to clipboard operation
unitxt copied to clipboard

Update CONTRIBUTING.md - update path name for activate

Open welisheva22 opened this issue 1 year ago • 5 comments

Looks like the bin directory may have been changed to Scripts -- the command seems to work when it's written as Scripts instead of bin

welisheva22 avatar Jul 29 '24 06:07 welisheva22

From python documentation:

It also creates a bin (or Scripts on Windows) subdirectory containing a copy/symlink of the Python binary/binaries (as appropriate for the platform or arguments used at environment creation time). It also creates an (initially empty) lib/pythonX.Y/site-packages subdirectory (on Windows, this is Lib\site-packages). If an existing directory is specified, it will be re-used.

elronbandel avatar Jul 29 '24 08:07 elronbandel

Thanks - then might it make sense to include both versions in the documentation, if some environments do use bin? How do you think we should handle this?

welisheva22 avatar Jul 29 '24 10:07 welisheva22

writing both sounds ideal

elronbandel avatar Jul 29 '24 17:07 elronbandel

Hi @welisheva22 - Can you update this PR with the above suggested changes?

yoavkatz avatar Aug 04 '24 09:08 yoavkatz

Sure - added another commit with the second command option, please review. Thank you.

welisheva22 avatar Aug 12 '24 19:08 welisheva22