tensorflow-hangul-recognition icon indicating copy to clipboard operation
tensorflow-hangul-recognition copied to clipboard

Performance issues in /hangul_model.py (by P3)

Open DLPerf opened this issue 2 years ago • 1 comments

Hello! I've found a performance issue in /hangul_model.py: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

  • .batch(BATCH_SIZE)(here) should be called before .map(_parse_function)(here).
  • .batch(BATCH_SIZE)(here) should be called before .map(_parse_function)(here).

Besides, you need to check the function called in map()(e.g., _parse_function called in .map(_parse_function)) whether to be affected or not to make the changed code work properly. For example, if _parse_function needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf avatar Aug 30 '21 08:08 DLPerf

Hello, I'm looking forward to your reply~

DLPerf avatar Nov 04 '21 09:11 DLPerf