Does sarama still guarantee message ordering?

[wenyihu6]

Description

Based on kafka documentation, "allowing retries while setting enable.idempotence to false and max.in.flight.requests.per.connection to greater than 1 will potentially change the ordering of records".

Sarama has a default configuration with a max of 3 retries, false idempotence, and a max of 5 in flight requests per connection.

Does this make the ordering guarantee in sarama no longer true?

[awoods187]

This is related to this bug https://github.com/IBM/sarama/issues/2619. We are observing this having a challenging impact on our downstream customers of Cockroach Labs

[richardartoul]

Should be fixed by #2943 if someone can review