sarama icon indicating copy to clipboard operation
sarama copied to clipboard

feat(consumer): return err from offsets commit

Open dnwe opened this issue 2 years ago • 2 comments

This changes the ConsumerGroupSession and OffsetManager interface in a way that’s compatible for users of these interfaces, but incompatible for implementers.

Contributes-to: IBM/sarama#2417

dnwe avatar Aug 31 '23 08:08 dnwe

As noted that even our own internals fail due the errcheck linter on offsetManager.Commit, it probably makes sense to defer this to v2

dnwe avatar Sep 01 '23 10:09 dnwe

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur. If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

github-actions[bot] avatar Jan 27 '24 06:01 github-actions[bot]