ibm-spectrum-scale-install-infra icon indicating copy to clipboard operation
ibm-spectrum-scale-install-infra copied to clipboard

Needs to add minimum supported Ansible version in the README

Open rajan-mis opened this issue 4 years ago • 11 comments

Needs to add minimum supported Ansible version in the README

rajan-mis avatar Apr 08 '20 10:04 rajan-mis

@digvijay2016 Thanks

rajan-mis avatar Apr 08 '20 11:04 rajan-mis

@digvijay2016 Thanks

rajan-mis avatar Apr 08 '20 11:04 rajan-mis

We are seeing our playbook failure on ansible 2.4.2.0

rajan-mis avatar Apr 08 '20 16:04 rajan-mis

@rajan-mis Instead of putting this requirement into the README, can we put this as an assert directly into the code? Thanks.

mamuthiah avatar Apr 12 '20 00:04 mamuthiah

@mamuthiah Yes we can do that. thanks

rajan-mis avatar Apr 12 '20 13:04 rajan-mis

I recommend both: prerequisite section in README and check in code

troppens avatar Apr 16 '20 16:04 troppens

I'm torn here, i understand why we would want to put a pre-req on the minimum, but are we actually going to be continually testing with that minimum version to validate that it holds true... otherwise we would never know when we started using a module that isn't provided at that min version -- until someone reports it.

whowutwut avatar Apr 17 '20 03:04 whowutwut

I have seen multiple failure with ansible version less than 2.7 . The same failure is happening on ubuntu and sles when i was doing unit testing of ubuntu and sles ansible code . I already implemented this validation and planning to create PR.

rajan-mis avatar Apr 17 '20 04:04 rajan-mis

Hit this on RHEL7.8 node. It appears that the Red Hat extras repo for RHEL7.x only goes up to ansible 2.4.2.0: https://access.redhat.com/downloads/content/rhel---7/x86_64/3030/ansible/2.4.2.0-2.el7/noarch/fd431d51/package

This would imply any RHEL7.x nodes to install ansible from some other location.

mrolyat avatar Jun 25 '20 20:06 mrolyat

Marking this as must fix:

  1. need to update README with minimum supported ansible version
  2. should provide guidance on where to get proper ansible version for RHEL7.x nodes that do no have access to >=2.7 ansible in their extras repos
  3. query underlying ansible version (and if it's installed) during prechecks and provide good problem determination guidance

mrolyat avatar Jun 25 '20 20:06 mrolyat

Re.: 3. Query underlying ansible version (and if it's installed) during prechecks

Ansible Galaxy has the concept of role metadata (defined in meta/main.yml), which also includes a min_ansible_version. Running ansible-galaxy install without the required version of Ansible will fail with an appropriate message.

One advantage of distributing the code through Galaxy... #106

acch avatar Aug 05 '20 08:08 acch