ibm-spectrum-scale-install-infra icon indicating copy to clipboard operation
ibm-spectrum-scale-install-infra copied to clipboard

Duplicate tasks in check.yml

Open acch opened this issue 4 years ago • 1 comments

The files core/common/tasks/check.yml and core/cluster/tasks/check.yml contain the same tasks. As all roles depend on core/common these tasks are redundant, and can be merged into a single file. Running these tasks twice simply increases runtime, and multiple definitions of the same variable are error-prone.

Duplicate tasks:

  • "check | Count daemon processes"
  • "check | Check if daemon is running"
  • "check | Set default daemon nodename"

acch avatar Nov 25 '20 07:11 acch

@acch Thanks. I was also thinking this but here we will have one issue and that we need to fix. if we are going to merge core/cluster/tasks/check.yml in the core/common/tasks/check.yml then core/cluster can not be used without core/common role but then this dependency always required SE package and scale_version variable but currently this independent role is getting consumed by ESS deployment and was also getting used by CNSS team independently without passing SE package or scale version because scale_version variable is not getting used in the core/cluster role. so we will have ton fix this before merging this into single. I also agree to remove this duplicate tasks. Thank you

rajan-mis avatar Nov 25 '20 08:11 rajan-mis