ibm-spectrum-scale-csi
ibm-spectrum-scale-csi copied to clipboard
adding option to disable primary fset dependency over filesets
Signed-off-by: badri-pathak [email protected]
Pull request checklist
This is the handle the feature request : https://github.ibm.com/IBMSpectrumScale/scale-core/issues/8553
Pull request type
Please check the type of change your PR introduces:
- [ ] Bugfix
- [x] Feature Enhancement
- [ ] Test Automation
- [ ] Code Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Community Operator listing
- [ ] Other (please describe):
What is the current behavior?
- In the current implementation, all the independent filesets are being mapped to the primary fset. VolumeID of pvc contains the softlink mapped with the actual data path of the created volumes.
What is the new behavior?
User can provide an optional/advanced parameter to disablePrimary Fset depedency over the filesets. After disabling the primaryfset, all the fsets will have their actual mounted path.
e.g. of the optional config Map with newly added variable
kind: ConfigMap
apiVersion: v1
metadata:
name: ibm-spectrum-scale-csi-config
namespace: ibm-spectrum-scale-csi-driver
data:
DRIVER_UPGRADE_MaxUnavailable: 70%
VAR_DRIVER_LOGLEVEL: TRACE
VAR_DRIVER_DISABLE_PRIMARY: "TRUE"
How risky is this change?
- [ ] Small, isolated change
- [x] Medium, requires regression testing
- [ ] Large, requires functional and regression testing
Images: ~operator: quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:disablePrimary_v8~ ~driver: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:disablePrimary_v9~
regression passed for FALSE
~quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:disablePrimary_v25~ ~quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:disablePrimary_v13~
one suggestion @badri-pathak , me and @Jainbrt discussed about variable name for this feature , can we make it as
VAR_DRIVER_PRIMARY_FILESYSTEM : "ENABLED/DISABLED" instead of VAR_DRIVER_DISABLE_PRIMARY as TRUE or FALSE because it is more easy to understand
latest images:
quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:disablePrimaryFS_v1 quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:disablePrimaryFS_v1
@saurabhwani5 addressed this issue https://github.ibm.com/IBMSpectrumScale/scale-core/issues/8917 Images quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:disablePrimaryFS_v6 quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:disablePrimaryFS_v1