gWhisper icon indicating copy to clipboard operation
gWhisper copied to clipboard

gwhisper crashes if the server does not support reflection

Open Hendrik-H opened this issue 3 years ago • 3 comments

Describe the bug When trying to connect to a server that does not support gRPC reflections then gWhisper crashes with a segfault. Would be nice if a message would be displayed instead that states that the server is missing the reflection support.

To Reproduce just try to connect to a server that does not support reflection

Expected behavior no crash but a clear message

Hendrik-H avatar Jan 21 '22 12:01 Hendrik-H

Thanks for reporting this. We should indeed not crash but write an understandable error message. We did until now not test on non-reflection server. A;so see related issue: #5 which we plan to work on in the next months

rainerschoe avatar Jan 21 '22 12:01 rainerschoe

in latest development version, as well as in latest release v3.3.1 I cannot reproduce. output when connecting to non reflection server:

> gwhisper 127.0.0.1
Parse failed.Parsed until: '127.0.0.1'
Possible Candidates:
  '127.0.0.1:'
  '127.0.0.1'
  '127.0.0.1 '
Reflection request not implemented; is the ServerReflection service enabled?

could you please give details (gwhisper version) and example crash.

rainerschoe avatar Jan 21 '22 18:01 rainerschoe

I'm using v3.3.1 and am connecting from x86 to a none reflect enabled gRPC service running on 390. the result is

Segmentation fault (core dumped)

Hendrik-H avatar Jan 21 '22 18:01 Hendrik-H