data-prep-kit icon indicating copy to clipboard operation
data-prep-kit copied to clipboard

Add pre commit gh action

Open shivdeep-singh-ibm opened this issue 1 year ago • 3 comments
trafficstars

Why are these changes needed?

Enables running pre-commit check on the pushed commits or pull request.

Related issue number (if any).

shivdeep-singh-ibm avatar May 09 '24 08:05 shivdeep-singh-ibm

@shivdeep-singh-ibm maybe its best to start over with the few files needed for this action? I recently did a PR that should have corrected all the pre-commit failures - and may be responsible for the conflicts above. Hopefully we won't get these next time.

daw3rd avatar May 15 '24 20:05 daw3rd

Hi @shivdeep-singh-ibm can you please also update .pre-commit-config.yaml file? (remove IBM Confidential header)

revit13 avatar Aug 11 '24 07:08 revit13

Please consider applying pre-commit only on the changes files in the pull request using --from-ref and --to-ref. This way the fixes can be applied incrementally.

revit13 avatar Aug 11 '24 08:08 revit13

This is not a high priority right now and it will have adverse impact on current PRs. This will be closed with no commit for now and picked later. @shivdeep-singh-ibm to creat an issue.

touma-I avatar Oct 14 '24 12:10 touma-I