data-prep-kit icon indicating copy to clipboard operation
data-prep-kit copied to clipboard

add license check transform

Open shivdeep-singh-ibm opened this issue 1 year ago • 4 comments
trafficstars

Why are these changes needed?

Add license check filter

Related issue number (if any).

shivdeep-singh-ibm avatar Jun 10 '24 15:06 shivdeep-singh-ibm

@shivdeep-singh-ibm This module (folder) should be called license filtering

Bytes-Explorer avatar Jun 17 '24 11:06 Bytes-Explorer

@shivdeep-singh-ibm it seems that the workflow- rules in transforms/code/license_check/Makefile needs to be changed (they refer to kfp_ray/v1 directory which does not exist). This causes the CI fail: Please see the Makefile in other code transforms to fix that.

make[4]: Leaving directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/ingest_2_parquet'
Using recursive workflow-build rule in license_check/
make[4]: Entering directory '/home/runner/work/data-prep-kit/data-prep-kit/transforms/code/license_check'
make -C kfp_ray/v1 workflow-build
make[5]: *** kfp_ray/v1: No such file or directory.  Stop.

revit13 avatar Jun 19 '24 07:06 revit13

@shivdeep-singh-ibm suggest you merge dev into this branch given some recent issues with versioning. See https://github.com/IBM/data-prep-kit/issues/355

daw3rd avatar Jun 28 '24 00:06 daw3rd

Also, not sure how far behind dev this is. It's probably a good idea to merge with dev

daw3rd avatar Jul 15 '24 19:07 daw3rd