css-gridish icon indicating copy to clipboard operation
css-gridish copied to clipboard

fix(prefix): make use of -- as a prefix standard

Open diego-codes opened this issue 6 years ago • 2 comments

It adds an extra - to the prefixing of class name so it is consistent with Carbon's prefixing standards. This is so that the $prefix value is respected in the building of sass code for Carbon users.

diego-codes avatar Jul 20 '18 17:07 diego-codes

Sadly we can’t make that update on the IBM grid package because it would conflict with Carbon’s prefix variable bx.

The class names themselves need to be updated to include -- in them like the rest of Carbon’s Sass. That way a consuming developer can declare their own $prefix and generate class names that are consistent all across.

diego-codes avatar Aug 20 '18 22:08 diego-codes

In that case, it sounds like the real fix is changing the prefix variable in Carbon right before the grid is imported and then switching the variable back right afterwards. Would that work?

Otherwise, a major change we need to do is prefix the prefix variable in Gridish.

seejamescode avatar Aug 21 '18 04:08 seejamescode