core-dump-handler icon indicating copy to clipboard operation
core-dump-handler copied to clipboard

Use error logger in timeout condition

Open timbuchwaldt opened this issue 2 years ago • 3 comments

timbuchwaldt avatar Oct 14 '22 06:10 timbuchwaldt

You've probably realized error! goes to std.err not std.out. Don't forget to sign it so the DCO passes. I want to get my patch to log4rs in the next release of CDH too https://github.com/estk/log4rs/commit/1b988edd87c47d1c85afe4af8dee0aff38254456 so I'll publish this as soon as you're ready.

No9 avatar Oct 14 '22 07:10 No9

Sorry about the dealy, there you go :)

timbuchwaldt avatar Oct 19 '22 12:10 timbuchwaldt

Hey @timbuchwaldt The test for timeout is failing now. Can you take a look when you have a minute.

No9 avatar Oct 19 '22 22:10 No9

Hey @timbuchwaldt January house keeping :) Is this still WIP or should we close it?

No9 avatar Jan 28 '23 15:01 No9

Hey @timbuchwaldt - Thanks for coming back to this. Do you want to land this now it's passing?

No9 avatar Feb 20 '23 08:02 No9