cloud-native-starter icon indicating copy to clipboard operation
cloud-native-starter copied to clipboard

Published 20 hours ago • verified publisher icon IBM

workshop full uses old version of istio 1.1.5

Open csantanapr opened this issue 4 years ago • 3 comments

workshop full https://github.com/IBM/cloud-native-starter/blob/master/workshop/00-prerequisites.md

Uses old version of istio 1.1.5 and this fails on new versions of k8s 1.16+ as Deployment is not part of apps/beta1

IKS doc uses istio 1.5.1, so as good step forward it would be good to keep all 3 places using same version of Istio between minikube and IKS

  • https://github.com/IBM/cloud-native-starter/blob/master/documentation/SetupLocalEnvironment.md
  • https://github.com/IBM/cloud-native-starter/blob/master/documentation/IKSDeployment.md
  • https://github.com/IBM/cloud-native-starter/blob/master/workshop/00-prerequisites.md

csantanapr avatar Jun 13 '20 03:06 csantanapr

@csantanapr Thanks for the comment I will change first to 1.5.1.

thomassuedbroecker avatar Jun 15 '20 06:06 thomassuedbroecker

Hi @thomassuedbroecker I submitted a PR at the time I opened the issue two days ago here #41

Would be awesome if you could review it and allow other folks to contribute to the this repository.

csantanapr avatar Jun 15 '20 12:06 csantanapr

Hi @csantanapr, sure I only noticed the issue. The review will take more time and thanks for your contribution.

thomassuedbroecker avatar Jun 15 '20 12:06 thomassuedbroecker