terraform-provider-ibm icon indicating copy to clipboard operation
terraform-provider-ibm copied to clipboard

ibm_is_lb_pool docs need clarification

Open powellquiring opened this issue 1 year ago • 3 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Affected Resource(s) or Datasource(s)

  • ibm_is_lb_pool

Description

https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_lb_pool

Docs state:

  • session_persistence_type - (Optional, String) The session persistence type, Enumeration type: source_ip, app_cookie, http_cookie

This info must be added:

  • [ ] Specify "null" if no session persistence is required
  • [ ] null is required for a route mode load balancer
  • [ ] scan the page for other similar issues

References

  • #0000

powellquiring avatar Feb 02 '24 21:02 powellquiring

looking into it

ujjwal-ibm avatar Feb 05 '24 03:02 ujjwal-ibm

@powellquiring session_persistence is an optional parameter while creating a load balancer pool. Hence there is no need to specify null if session persistence is refuired. Also, session_persistence_type can be removed from the config to remove the session_persistence from the pool and no need to set null explicitly, because session_persistence_type is an optional.

deepaksibm avatar Feb 16 '24 09:02 deepaksibm

Makes sense. Clean up the docs to indicate:

  • [ ] having no session_persistence variabl emeans no session persistence
  • [ ] it must be left off for route mode
  • [ ] Verify that If session_persistence is initially set (apply) then removed (apply) that the resource has no session_persistence

powellquiring avatar Feb 16 '24 18:02 powellquiring