Create key with policy override resource

[Sidd-kp]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[Sidd-kp]

Dependencies: CreateKeyWithPolicyOverrides SDK support Set Key Policy SDK support for enabled parameter.

[harshit777]

FOUND SECRETS: File: ibm/service/kms/resource_ibm_kms_key_with_policy_overrides_test.go Line: 23 Type: Base64 High Entropy String failure

Can u address this please !!

[harshit777]

Also can attach the evidences to the resource provisioning !

[Sidd-kp]

[Sidd-kp]

All test results Note: I have commented out the following test case as it requires a paid account:

{
          Config: testAccCheckIBMKmsResourceRootkeyWithCOSConfig(instanceName, resourceName, keyName, cosInstanceName, bucketName),
          Check: resource.ComposeTestCheckFunc(
	          resource.TestCheckResourceAttr("ibm_kms_key.test", "key_name", keyName),
          ),
},

[Sidd-kp]

[Sidd-kp]

Root Key, Standard Key, Imported Root Key, Imported Standard Key

[harshit777]

All test results Note: I have commented out the following test case as it requires a paid account:

{
          Config: testAccCheckIBMKmsResourceRootkeyWithCOSConfig(instanceName, resourceName, keyName, cosInstanceName, bucketName),
          Check: resource.ComposeTestCheckFunc(
	          resource.TestCheckResourceAttr("ibm_kms_key.test", "key_name", keyName),
          ),
},

Nice! Work, LGTM, one suggestion instead of commenting we can use t.Skip() inside the function to skip it while testing, in that case we will not need to comment it !

[hkantare]

fix conflicts

[Sidd-kp]

4 of 5 of the test cases are passing. The last one requires a paid account.