Deprecate Whitelist for IBM-cloud-databases. Introduce allowlisting

[omaraibrahim]

In the api version 5 whitelist was deprecated and allowlist was introduced. In our strive for feature parity, in the following PR I deprecated whitelist and introduced allowlist.

This involved:

• Deprecating whitelist in our data_source_ibm_database and introducing allowlist
• Deprecating whitelist in our database resource and introducing allowlist
• Updating tests

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseDataSource_basic'
--- PASS: TestAccIBMDatabaseDataSource_basic (597.39s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	598.703s
...

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMEDBDatabaseInstanceBasic'
--- PASS: TestAccIBMEDBDatabaseInstanceBasic (1836.72s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1837.595s

[hkantare]

@omaraibrahim Can you add a migration testcase from whitelist to allowlist

[omaraibrahim]

@hkantare I've gone ahead and added migration tests. I've also modified the code to address some concerns and ensure a seemless migration to allowlist - while retaining full functionality for whitelist.

Migration tests can be found here: https://github.com/IBM-Cloud/terraform-provider-ibm/blob/9845af30042b7d088c7343b6a078bfebc8bf83da/ibm/service/database/resource_ibm_database_postgresql_test.go#L105