IBAMR
IBAMR copied to clipboard
IBAMR
Make get functions public in IBMethod.
Currently, the IB data in IBMethod during the middle of a time step is inaccessible outside of IBMethod. The data is owned by the class IBMethod and therefore can not be retrieved via LDataManager. This PR makes the get functions public.
IBAMR Pull Request Checklist
- [x] Does the test suite pass?
- [x] Was clang-format run?
- [x] Were relevant issues cited? Please remember to add
Fixes #12345to close the issue automatically if we are fixing the problem. - [x] Is this a change others will want to know about? If so, then has a changelog entry been added?
- [x] If new data structures have been added to a class then have they been set up appropriately for restarts? If so, ensure that the restart version number is incremented.
- [x] Does this change include a bug fix or new functionality? If so, a new test or tests should be added. New tests should run quickly (less than a minute in release mode). If possible, an older test should gain a new option so that we do not need to compile more test executables.
- [x] Did you (if your account has permission to do so) set relevant labels on GitHub for the pull request?
Looks good. I am inclined to keep the interface related to implicit time stepping protected for now, since I think those interfaces are likely to change as we get some effective preconditioners implemented over the next several months. However, if you need access now or soon, I guess that it's OK to go ahead and make it public.
Looks good. I am inclined to keep the interface related to implicit time stepping protected for now, since I think those interfaces are likely to change as we get some effective preconditioners implemented over the next several months. However, if you need access now or soon, I guess that it's OK to go ahead and make it public.
I really only need access to the position and velocity data. I will revert the linearized functions.
